Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add ARP static entries #3288

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 23, 2023

Change Summary

Implement arp static entries

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

type: dict
keys:
  arp:
    type: dict
    keys:
[...]
      static_entries:
        type: list
        description: Static ARP entries.
        items:
          type: dict
          keys:
            ipv4_address:
              type: str
              required: true
              description: ARP entry IPv4 address.
            vrf:
              type: str
              description: ARP entry VRF - default to "default".
            mac_address:
              type: str
              description: ARP entry MAC address.
              required: true
              pattern:  "^[0-9A-Fa-f]{1,4}\\.[0-9A-Fa-f]{1,4}\\.[0-9A-Fa-f]{1,4}$"

sorting is done as on EOS CLI:

ceos2(config)#show run | grep arp
arp aging timeout default 666
arp vrf BLAH 42.42.42.42 21:23:ca:fe:be:ef arpa
arp vrf defauls 42.42.42.42 ca:fe:ca:fe:be:ef arpa
arp 42.42.42.42 ca:fe:ca:fe:be:ef arpa
arp vrf defaulu 42.42.42.42 ca:fe:ca:fe:be:ef arpa

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 23, 2023
@gmuloc gmuloc marked this pull request as ready for review October 23, 2023 12:02
@gmuloc gmuloc requested review from a team as code owners October 23, 2023 12:02
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 24, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team October 24, 2023 15:56
@carlbuchmann carlbuchmann added one approval This PR has one approval and is only missing one more. and removed one approval This PR has one approval and is only missing one more. labels Oct 24, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested configuration on DUT.

@carlbuchmann carlbuchmann merged commit 44ef7ee into aristanetworks:devel Oct 24, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants