Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Implement NAT profiles + ethernet interfaces CLI #3294

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Feat(eos_cli_config_gen): Implement NAT profiles + ethernet interfaces CLI #3294

merged 2 commits into from
Nov 2, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 24, 2023

Change Summary

  • Re-using the template from interface for profiles as it works fine (tested on cEOS)
  • Not re-using the template for documentation as the tables were not appropriate
  • Added the config for ip nat service-policy <NAME>

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

TO UPDATE

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 24, 2023 15:13
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 24, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team October 25, 2023 09:23
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 25, 2023
carlbuchmann
carlbuchmann approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • test configs on dut
  • reviewed schema

@carlbuchmann carlbuchmann merged commit e8f58a4 into aristanetworks:devel Nov 2, 2023
39 checks passed
@gmuloc gmuloc removed the role: eos_designs issue related to eos_designs role label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmuloc @carlbuchmann @ClausHolbechArista