Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add default_mgmt_method to be used later in new management settings. #3328

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Nov 8, 2023

Change Summary

Add default_mgmt_method to be used later in new management settings.

Component(s) name

arista.avd.eos_designs

Proposed changes

default_mgmt_method: <str>

This is a no-op currently.

How to test

This has no functionality right now. Tests will be added as part of the associated management protocol PRs

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Nov 8, 2023
@carlbuchmann carlbuchmann self-requested a review November 8, 2023 17:20
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team November 9, 2023 08:30
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Nov 9, 2023
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once docstring is updated

@carlbuchmann carlbuchmann merged commit 881db7f into aristanetworks:devel Nov 9, 2023
36 checks passed
jonxstill pushed a commit to jonxstill/ansible-avd that referenced this pull request Nov 14, 2023
…management settings. (aristanetworks#3328)

Co-authored-by: Carl Buchmann <carl.buchmann@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants