Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Fix doc generation #3405

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Doc: Fix doc generation #3405

merged 1 commit into from
Dec 5, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Dec 5, 2023

Change Summary

When hiding keys in documentation generation, some hidden key table options were leaking generating extra tables.

Component(s) name

pyavd

Proposed changes

Ignoring hidden key table options

How to test

run pre-commit

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners December 5, 2023 16:24
@gmuloc gmuloc added this to the v4.5.0 milestone Dec 5, 2023
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Dec 5, 2023
carlbuchmann
carlbuchmann approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodaA tgodaA removed the one approval This PR has one approval and is only missing one more. label Dec 5, 2023
tgodaA
tgodaA approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit f087512 into devel Dec 5, 2023
37 checks passed
@gmuloc gmuloc deleted the doc-fix branch December 5, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@tgodaA tgodaA tgodaA approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: Doc role: eos_designs issue related to eos_designs role state: Documentation role Updated
Projects
None yet
Milestone
v4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gmuloc @carlbuchmann @ClausHolbechArista @tgodaA