Fix(eos_designs): Correct logic for VRF RD/RT overrides #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
state: CI Updated
gmuloc
approved these changes
Dec 15, 2023
gmuloc
added
the
one approval
bjmeuer
approved these changes
Dec 15, 2023
|
Hi @forcecity - can you please check the changes on your side and confirm that they address your concerns? Thanks again for catching this! |
|
This change looks good to me. Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Correct logic for VRF RD/RT overrides
Related Issue(s)
Fixes the two issues found by @forcecity mentioned on #3419
Checklist
Repository Checklist