Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): IPv4/IPv6 address-family configuration for bgp_peer_groups defined under network services. #3887

Merged
merged 10 commits into from May 7, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Provide facility to configure per address family settings for a BGP peer group defined under network services.

Related Issue(s)

Fixes #3873

Component(s) name

arista.avd.eos_designs

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Apr 19, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 19, 2024 15:25
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners April 19, 2024 15:25
@ClausHolbechArista
Copy link
Contributor

Moving to draft until comments have been addressed.

@ClausHolbechArista ClausHolbechArista marked this pull request as draft April 23, 2024 08:52
@Vibhu-gslab Vibhu-gslab force-pushed the bgp_peer_groups branch 4 times, most recently from 4cea0e7 to 7b9904b Compare April 25, 2024 15:21
@github-actions github-actions bot removed the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Apr 25, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 26, 2024 07:05
@Vibhu-gslab Vibhu-gslab marked this pull request as draft April 26, 2024 16:36
@Vibhu-gslab Vibhu-gslab force-pushed the bgp_peer_groups branch 3 times, most recently from 21247a3 to 4125b71 Compare April 27, 2024 02:48
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 27, 2024 02:50
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 29, 2024 13:13
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team May 3, 2024 11:26
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label May 3, 2024
@MaheshGSLAB MaheshGSLAB requested a review from a team May 3, 2024 13:36
@ClausHolbechArista ClausHolbechArista merged commit 3ea9e2c into aristanetworks:devel May 7, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eos_designs: IPv4 / IPv6 address-family configuration for bgp_peer_groups defined under network services.
3 participants