New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): IPv4/IPv6 address-family configuration for bgp_peer_groups defined under network services. #3887
Merged
ClausHolbechArista
merged 10 commits into
aristanetworks:devel
from
Vibhu-gslab:bgp_peer_groups
May 7, 2024
Merged
Feat(eos_designs): IPv4/IPv6 address-family configuration for bgp_peer_groups defined under network services. #3887
ClausHolbechArista
merged 10 commits into
aristanetworks:devel
from
Vibhu-gslab:bgp_peer_groups
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
Apr 19, 2024
ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/DC1-BL1A.cfg
Outdated
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
Moving to draft until comments have been addressed. |
Vibhu-gslab
force-pushed
the
bgp_peer_groups
branch
4 times, most recently
from
April 25, 2024 15:21
4cea0e7
to
7b9904b
Compare
github-actions
bot
removed
the
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
label
Apr 25, 2024
Vibhu-gslab
force-pushed
the
bgp_peer_groups
branch
from
April 25, 2024 15:22
7b9904b
to
7f53448
Compare
Vibhu-gslab
force-pushed
the
bgp_peer_groups
branch
3 times, most recently
from
April 27, 2024 02:48
21247a3
to
4125b71
Compare
Vibhu-gslab
force-pushed
the
bgp_peer_groups
branch
from
April 29, 2024 07:02
4125b71
to
af8b995
Compare
...e_collections/arista/avd/roles/eos_designs/docs/tables/network-services-vrfs-bgp-settings.md
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
bgp_peer_groups
branch
from
April 29, 2024 10:44
af8b995
to
4a6f588
Compare
Vibhu-gslab
force-pushed
the
bgp_peer_groups
branch
from
April 29, 2024 13:00
4a6f588
to
95a2959
Compare
ClausHolbechArista
requested changes
Apr 29, 2024
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/router_bgp.py
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
bgp_peer_groups
branch
from
April 30, 2024 04:58
76918e5
to
c036e34
Compare
Vibhu-gslab
force-pushed
the
bgp_peer_groups
branch
from
April 30, 2024 09:15
875f31f
to
4685c97
Compare
…r_groups defined under network services.
Vibhu-gslab
force-pushed
the
bgp_peer_groups
branch
from
May 2, 2024 08:48
4685c97
to
062c03f
Compare
ClausHolbechArista
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
May 3, 2024
MaheshGSLAB
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_designs)
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Provide facility to configure per address family settings for a BGP peer group defined under network services.
Related Issue(s)
Fixes #3873
Component(s) name
arista.avd.eos_designs
Checklist
Repository Checklist