Kirki_Helper::compare_values contains/in PHP warning if value doesn't exist in array [fix] #1828

CaptJiggly · 2018-03-11T14:26:25Z

Issue description:

Everything is working great (The simplifying is much more easy on the eyes as well), but there was one little issue I found (One line was needed to be exact).

Version used:

(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)

develop-branch

Using theme_mods or options?

N/A

Code to reproduce the issue (config + field(s))

The value/default value being an empty array.

aristath · 2018-03-11T14:29:11Z

Good catch, I missed that one! 👍
Pushed a fix, should be ok now

* develop: (73 commits) fixes #1730 fixes #1830 GDPR: Load webfont-loader locally Update fonts fixes #1834 Apply WordPress Coding Standards Update kirki-helper-class.md see #1797 cleanup unused vars See #1807 Additional fix for #1809 fixes #1828 fixes #1808 fix #1814 fix #1797 fixes #1809 Update sortable.md fixes #1787 update webfonts & grunt changelog ... # Conflicts: # modules/postmessage/class-kirki-modules-postmessage.php

aristath closed this as completed in 92c330e Mar 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kirki_Helper::compare_values contains/in PHP warning if value doesn't exist in array [fix] #1828

Kirki_Helper::compare_values contains/in PHP warning if value doesn't exist in array [fix] #1828

CaptJiggly commented Mar 11, 2018 •

edited

aristath commented Mar 11, 2018

Kirki_Helper::compare_values contains/in PHP warning if value doesn't exist in array [fix] #1828

Kirki_Helper::compare_values contains/in PHP warning if value doesn't exist in array [fix] #1828

Comments

CaptJiggly commented Mar 11, 2018 • edited

Issue description:

Version used:

Using theme_mods or options?

Code to reproduce the issue (config + field(s))

aristath commented Mar 11, 2018

CaptJiggly commented Mar 11, 2018 •

edited