Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to import tags from Aseprite as non-looping #43

Closed
AristurtleDev opened this issue Feb 21, 2023 · 3 comments
Closed

Add ability to import tags from Aseprite as non-looping #43

AristurtleDev opened this issue Feb 21, 2023 · 3 comments
Assignees
Labels
🐞 Bug A bug has been identified and need to be fixed. 🔺 Priority: High The issue or pull request made needs to be resolved as soon as possible. ✈ Status: In Progress This issue or pull request is currently being worked on.
Milestone

Comments

@AristurtleDev
Copy link
Owner

Description

In the previous version of MonoGame.Aseprite it was possible to add the text [oneshot] to a tag in Aseprite, and then when it was imported, it was imported as a non-looping animation.

This was not carried over with the Version 4.0.0 update and should be re-implemented.

Steps to Reproduce

  1. Create an Aseprite file with multiple frames
  2. Create a Tag named anything as long as it has [oneshot] at the end of the name. (e.g. open_door[oneshot]
  3. Import the Asperite file in game using AsepriteFile.Load()
  4. Create a SpriteSheet with the SpriteSheetProcessor
  5. Create an AnimatedSprite based on the open_door tag
  6. Update the AnimatedSprite in the Update method and draw it in the Draw method
  7. Run the game

Expected Behavior

Since the tag has [oneshot] at the end of the name, it's expected it to not loop in line with the previous version of the library.

Actual Behavior

The animation continues to loop

Configuration

  • .NET Version: net6.0
  • MonoGame Version: 3.8.1
  • Aseprite Version: 1.3-beta21
  • Operating System: Mac OS Monterey 12.6.1
  • *Architecture: x64

Other Information

No other information to provide.

@AristurtleDev
Copy link
Owner Author

Reference issue #20

@AristurtleDev AristurtleDev self-assigned this Feb 21, 2023
@AristurtleDev AristurtleDev added the 🐞 Bug A bug has been identified and need to be fixed. label Feb 21, 2023
@AristurtleDev AristurtleDev added this to the Version 4.1.0 milestone Feb 22, 2023
@AristurtleDev AristurtleDev added 🔺 Priority: High The issue or pull request made needs to be resolved as soon as possible. ✈ Status: In Progress This issue or pull request is currently being worked on. labels Feb 27, 2023
@AristurtleDev
Copy link
Owner Author

Aseprite 1.3-rc1 now has the "repeat" field for tags. This will be implemented as part of #69 .

@AristurtleDev
Copy link
Owner Author

As of version 5.0.0, AnimatedSprite.Play has been added which has a loop count override.
Further, Asperite 1.3-rc1 added new Repeat tag which can be used to set the tag as non looping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug A bug has been identified and need to be fixed. 🔺 Priority: High The issue or pull request made needs to be resolved as soon as possible. ✈ Status: In Progress This issue or pull request is currently being worked on.
Projects
None yet
Development

No branches or pull requests

1 participant