Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate key/value pairs #3

Open
patbenatar opened this issue May 22, 2012 · 6 comments
Open

Duplicate key/value pairs #3

patbenatar opened this issue May 22, 2012 · 6 comments

Comments

@patbenatar
Copy link

There appears to be a grip of duplicate key/value pairs in this hash.. For example Ł is in there as a key twice. Some of the duplicates have the same key with different values. I noticed this cause ExecJS complains about duplicate keys in hashes when it compiles Coffee to JS (I ported the hash to Coffee real quick).

@aristus
Copy link
Owner

aristus commented May 22, 2012

Good catch! I have a patch for both JavelinJS and this branch, in my mythical spare time.

@patbenatar
Copy link
Author

I was working on a fixed hash but then ran into the duplicates that have different values and wasn't sure what to do with them.

@aristus
Copy link
Owner

aristus commented May 22, 2012

Hmm. I won't have time to finish my patch for a while. Maybe send / post the dupes? We can probably work out which values are "right".

@patbenatar
Copy link
Author

Here's what I found:

dupe keys (removed):

    'Ł':'l',
    'ł':'l',
    '̣':'l',
    '̈':'n',
    '̃':'p',
    '̩':'s',

dupe keys with different values:

    '̈':'t', # removed this one for now
    '̈':'n',

    '̊':'w',
    '̊':'y', # removed this one for now

Here's the updated hash with above changes: https://gist.github.com/2772409

@patbenatar
Copy link
Author

Also noticed some missing ones that are relatively common:

Ææ => should be replaced with "ae"
Ðð => should be replaced with "th", even though the shape is more of a "d"
Œœ => should be replaced with "oe"

And some inaccurate ones:
Þþ => should be replaced with "th"
ß => should be replaced with either "ss" or "sz"

I'll go ahead and add the missing ones. What do you think about the inaccurate ones?

@patbenatar
Copy link
Author

Here's an updated hash with the missing ones added and inaccurate ones fixed: https://gist.github.com/2772435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants