Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V 2.0.0 has "Confused" default overloads #14

Closed
Smurf-IV opened this issue Jul 29, 2020 · 3 comments
Closed

V 2.0.0 has "Confused" default overloads #14

Smurf-IV opened this issue Jul 29, 2020 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@Smurf-IV
Copy link

When assuming one can use default values, the following is returned in the compiler
image

@Smurf-IV Smurf-IV changed the title V 2.0.0 has "Confused" default overrides V 2.0.0 has "Confused" default overloads Jul 29, 2020
@arivera12
Copy link
Owner

One cancellation token is when reading the stream(the first one), the other cancellation token is when interop with JavaScript(the second one).

@arivera12 arivera12 self-assigned this Jul 29, 2020
@arivera12 arivera12 added documentation Improvements or additions to documentation question Further information is requested labels Jul 29, 2020
@arivera12
Copy link
Owner

arivera12 commented Jul 29, 2020

You will still need to specify the contentType or the buffersize so the compiler doesn't get confused and know which method to use.

@arivera12
Copy link
Owner

arivera12 commented Jul 29, 2020

There is not too much I could do here those overload are needed, if I remove default values developers would still need to specify them, one thing I could do it's remove the default values but I want to left them for reference for the developers to know which value should be safe or ok to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants