Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove composer.lock #126

Closed
cykirsch opened this issue Nov 6, 2020 · 1 comment
Closed

Remove composer.lock #126

cykirsch opened this issue Nov 6, 2020 · 1 comment

Comments

@cykirsch
Copy link
Contributor

cykirsch commented Nov 6, 2020

As of now I haven't experienced any issues with this, but I noticed the conversation #95 (comment).

I'm curious, with the release of composer version 2, do you still have the issues with circleci?
@arkaitzgarro
Copy link
Owner

Hey @cykirsch,

composer.lock file is not part of the repository anymore! It was removed when we moved from circleci to GitHub actions, as they offer a much better way to configure a matrix of PHP/Laravel jobs.

And yes, Composer version 2 is a huge improvement when it comes to performance, both in memory usage and installation speed, as you can see in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arkaitzgarro @cykirsch