Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple maintenance improvements #1255

Merged
merged 4 commits into from Sep 27, 2021
Merged

Simple maintenance improvements #1255

merged 4 commits into from Sep 27, 2021

Conversation

a1346054
Copy link
Contributor

No description provided.

@earthlng
Copy link
Contributor

Looks good to me. Thanks!

@earthlng earthlng merged commit 5cdea95 into arkenfox:master Sep 27, 2021
@Xathros1
Copy link

Xathros1 commented Sep 28, 2021

I got after running prefsCleaner the message
grep: Invalid regular expression
Bildschirmfoto-von-2021-09-28-13-54-24

#1255 Typo in prefsCleaner.sh?
Line 51, bracket set incorrectly?

Change
done <<< "$(grep -E \"$prefexp\" user.js)"
To
done <<< "($grep -E \"$prefexp\" user.js)"
??

Doesn't look that it's resetting the settings in both cases. But in the changed one I don't get the "grep" message.

@a1346054
Copy link
Contributor Author

I'll look into this.

@a1346054
Copy link
Contributor Author

I have the fix for this ready, am just investigating why the current version works here too and not for you.

@a1346054
Copy link
Contributor Author

@Xathros1 #1258 will fix that issue for you, if you wish to apply it yourself.

@Xathros1
Copy link

@Xathros1 #1258 will fix that issue for you, if you wish to apply it yourself.

Fixed it for me, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants