v97

[Thorin-Oakenpants]

• 0605: see https://bugzilla.mozilla.org/show_bug.cgi?id=1355460

[szepeviktor]

0605: see bugzilla.mozilla.org/show_bug.cgi?id=1355460

Mozilla guys are very tricky!

[Thorin-Oakenpants]

Mozilla guys are very tricky!

I don't see an issue. About the only time I think this would trigger without you wanting to actually visit is when you left click to drag and drop. I only added it to be consistent

edit: to be clear this is for existing bookmarks, not creating them

[Thorin-Oakenpants]

am done with #1366 and ready to merge - awaiting reviews

[GlassGruber]

Mozilla guys are very tricky!

I don't see an issue. About the only time I think this would trigger without you wanting to actually visit is when you left click to drag and drop. I only added it to be consistent

Wouldn't this be triggered when reordering bookmarks?

[Thorin-Oakenpants]

Wouldn't this be triggered when reordering bookmarks?

IDK and don't care, I disabled it :) I use a speed dial for my stuff, otherwise my toolbar has

• three folders and then four bookmarks - i never need to reorder anything - the rest of the space on the toolbar if for drg n drop URLs for me to follow up on etc
• i never use the bookmarks manager

So that's what I meant when I said drag n drop. I have no idea what you mean by "reordering bookmark" and how that differs from what I said

[GlassGruber]

So that's what I meant when I said drag n drop. I have no idea what you mean by "reordering bookmark" and how that differs from what I said

• i never use the bookmarks manager

I do sometimes use the bookmark manager and the usability... well is not really the main sell point of the tool IMO. It happens sometimes that I need to rearrange bookmarks that have been saved in weird order or similar.

IDK and don't care, I disabled it :)

Disable first, ask questions later. Sounds like a good plan. 😎

[GlassGruber]

Wouldn't this be triggered when reordering bookmarks?
I have no idea what you mean by "reordering bookmark" and how that differs from what I said

Mmm I messed it a bit, I actually really intended a question but that negation morphed it in an assertion, correct phrase is:

Would this be triggered when reordering bookmarks?

Anyway yea, disabled and done.

[crssi]

❤️