Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v105 #1541

Merged
merged 14 commits into from Oct 4, 2022
Merged

v105 #1541

merged 14 commits into from Oct 4, 2022

Conversation

Thorin-Oakenpants
Copy link
Contributor

No description provided.

user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
user.js Outdated Show resolved Hide resolved
it means prefscleaner resets them, and these all have an UI and users can deal with them once - also, less shit in the user.js
Copy link
Collaborator

@fxbrit fxbrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more trimming is always a good news, LGTM :-)

@opusforlife2
Copy link

What does sessionstore interval do for us, exactly? I have seen the override recipe for session restore and that seems to be the only use case.

For those who don't use session restore, can this value be set to something insanely high (or turned off somehow) so that Firefox doesn't waste time doing this?

@Thorin-Oakenpants
Copy link
Contributor Author

Thorin-Oakenpants commented Oct 4, 2022

it does nothing for us, hence moved. it was added way back in the early days, so seven years ago? I'm not going to comment on the merits of the number of disk writes and older machines, and TBH I think those days have sailed. Privacy wise it does absolutely zero. There will always be some state written to disk, changing how often it is updated does nothing

edit: also it has nothing to do with session restore recipe

@Thorin-Oakenpants
Copy link
Contributor Author

Thorin-Oakenpants commented Oct 4, 2022

I'll push this tomorrow because I changed the date in the user.js to 5th Oct :)

and I'm also lazy as fuck and I want to make releases late so people release that these changes are minor and not a reason to not update (there are stupid comparisons being made about librewolf vs arkenfox updates - one is an application, the other is a pref change or two with minimal effect these days, if any effect at all: they're not comparable AT ALL)

from the reddit link: what a fucking moron

I just checked, as I'm writing this Librewolf is on 104.0.2 and was updated yesterday. Arkenfox, according to their github, is on 103 and was last updated 23 days ago. So we must have different ideas of what slow is.

edit: also "last updated 23 days ago" doesn't mean anything, it needs to be measured against the date of the Firefox release. Every fucking arkenfox release is on average a four+ week cycle. again .. what a moron

edit: also comparing a .0.2 release to an arkenfox one is also moronic ... what a moron

edit: also linking to this so it gets publicity: https://github.com/privacyguides/privacyguides.org/discussions/423#discussioncomment-3782610

@Thorin-Oakenpants Thorin-Oakenpants merged commit 4e3a64b into master Oct 4, 2022
@Thorin-Oakenpants Thorin-Oakenpants deleted the Thorin-Oakenpants-patch-1 branch October 4, 2022 17:15
@fxbrit
Copy link
Collaborator

fxbrit commented Oct 5, 2022

I thought stay away from reddit was rule number one, shame on you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants