Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the absence of the WMIC utility #1624

Closed
dartraiden opened this issue Feb 5, 2023 · 3 comments
Closed

Handle the absence of the WMIC utility #1624

dartraiden opened this issue Feb 5, 2023 · 3 comments

Comments

@dartraiden
Copy link

Starting from Windows 11 WMIC is an optional component and can be uninstalled by the user. Both prefsCleaner and updater use WMIC to construct the name of the backup file. If the WMIC is missing, an error The filename, directory name, or volume label syntax is incorrect appears. Backup will not be created.

The error text is incomprehensible to the user. I suggest adding a check for the presence of WMIC. If WMIC is missing, display a warning that the backup will not be created and skip the whole backup procedure.

@earthlng
Copy link
Contributor

earthlng commented Mar 10, 2023

Hi and thanks for the report.

I've replaced WMIC with a powershell command to get the date-timestamp in the Updater.bat.
Can you test if that works for you?
If it does, I'll make the change in the prefsCleaner as well.

@dartraiden
Copy link
Author

Yes, the new updater.bat works correctly 👍

@earthlng
Copy link
Contributor

Okay, thanks for the feedback. I made the change in the prefsCleaner too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants