network.IDN_show_punycode #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my draft for network.IDN_show_punycode added under 2600 but it would maybe also fit under 0800 (?) the title and that one line are quite long, feel free to improve the wording etc.
It seems the optimal location to me. |
|
pyllyukko has the following url included, is it too much if we add it too? |
|
Your choice is better! |
shortened and evened out lines, added that extra link. I changed "Internationalized Domain Names" to IDNs to save space and then realized the kb and wiki articles don;t even say what IDN stands for, so I put it back. Also swapped the order and wording of the pref to make it consistent with the action. Instead of - "2672: eliminate possible .. show_punycode", true)" - "2672: force Punycode .. show_punycode", true)"
|
@earthlng If you're happy with my little modifications, merge the pull request and then commit to master |
removed the 'period' at the end of the pref description (we usually don't have one there) and aligned the 2nd line of the downside a bit nicer.
|
thx Pants, much better with your mods |
network.IDN_show_punycode draft modifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my draft for
network.IDN_show_punycodeadded under 2600 but it would maybe also fit under 0800 (?)
the title and that one line are quite long, feel free to improve the wording etc.