Update Gradle, Kotlin, and Compose versions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkivanov
requested changes
Aug 14, 2022
| @@ -79,9 +91,13 @@ private fun Board(board: Board) { | |||
| return | |||
| } | |||
|
|
|||
| Column { | |||
| Column( | |||
| modifier = Modifier.padding(COL_PADDING) | |||
There was a problem hiding this comment.
Why do we need paddings now? Could you please attach a screenshot?
There was a problem hiding this comment.
With padding:
Without padding:
I see that I should make it more to match your version. Here it is with 32.dp padding:
I notice it displays the title less prominently (at least on my Windows 11 desktop).
|
Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making your code available. I'm planning to use it in a class I'll be teaching.
I decided to update to a recent version of Compose, which required updating Gradle and Kotlin versions. The biggest headache was the change from
androidx.compose.desktop.Windowtoandroidx.compose.ui.window.Window. I'm new to Compose, so my changes might not be the best.