Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Router to stack sub-package and rename it to StackRouter #134

Closed
arkivanov opened this issue Jul 9, 2022 · 0 comments · Fixed by #142
Closed

Move Router to stack sub-package and rename it to StackRouter #134

arkivanov opened this issue Jul 9, 2022 · 0 comments · Fixed by #142
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@arkivanov
Copy link
Owner

Router organizes children as a stack - there is always one resumed child on top of the stack, children in the back stack are either stopped or destroyed. In the future, there could be other kinds of routers, e.g. a router that organizes children as a list (all children are active, no back stack).

To allow the room for additional routers, it is necessary to move Router and all its surroundings to stack sub-package. And also rename it to StackRouter - to make it clear that it acts as a stack. It also makes sense to rename RouterState to ChildStack.

This change should be done via deprecation cycle.

@arkivanov arkivanov changed the title Move Router to "stack" sub-package and rename it to StackRouter Move Router to stack sub-package and rename it to StackRouter Jul 9, 2022
@arkivanov arkivanov added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 9, 2022
@arkivanov arkivanov self-assigned this Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant