Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken documentation links in samples' readme files #23

Closed
arkivanov opened this issue Jan 28, 2022 · 3 comments
Closed

Broken documentation links in samples' readme files #23

arkivanov opened this issue Jan 28, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@arkivanov
Copy link
Owner

arkivanov commented Jan 28, 2022 •
edited

READMEs with broken links:

The proper link is https://arkivanov.github.io/Decompose/samples/ with a corresponding hash fragment.

Also would be good to add a similar README file to the dynamic-feature sample.
@arkivanov arkivanov added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Jan 28, 2022
@Shabinder Shabinder mentioned this issue Jan 28, 2022
Merged
@arkivanov
Copy link
Owner Author

The Counter sample README is fixed via #24

@arkivanov
Copy link
Owner Author

The Master-Detail sample README is fixed via #25

@arkivanov
Copy link
Owner Author

The Dynamic Feature sample's README was added in #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arkivanov