Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

rxjs as peerDependency #93

Closed
carmanchris31 opened this issue Nov 13, 2018 · 1 comment
Closed

rxjs as peerDependency #93

carmanchris31 opened this issue Nov 13, 2018 · 1 comment

Comments

@carmanchris31
Copy link

carmanchris31 commented Nov 13, 2018 •
edited

This package is great but I lost some valuable time troubleshooting SVGs not appearing in some circumstances. I eventually found this was occurring when they were loaded from cache and then to the 'of' function not being defined and finally to the rxjs version mismatch (5 vs 6).

We can save time for people like me (e.g. here and here) by declaring rxjs 6 as a peerDependency. That way a warning will be surfaced when installing/building if the version is not met.
@arkon arkon closed this as completed in d530178 Nov 20, 2018
@arkon
Copy link
Owner

arkon commented Nov 20, 2018

Sorry, that's definitely a miss on my part! Added in v8.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arkon @carmanchris31