Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closure scopes should be raw pointers #35

Closed
SuperFola opened this issue Oct 5, 2019 · 1 comment
Closed

Closure scopes should be raw pointers #35

SuperFola opened this issue Oct 5, 2019 · 1 comment
Labels
ark/virtual machine Related to the ark virtual machine enhancement New feature or request 👍 good first issue Good for newcomers
Projects
v3.1.0
Milestone
3.1.0

Comments

@SuperFola
Copy link
Member

SuperFola commented Oct 5, 2019 •
edited
Loading

Instead of using shared pointer, we should have raw pointers to elements in a std::list owned by the VM. (see comment)

Description related data owned by the VM should also be moved to a lighter structure (Ark::State)
@SuperFola SuperFola added enhancement New feature or request 👍 good first issue Good for newcomers ark/virtual machine Related to the ark virtual machine labels Oct 5, 2019
@SuperFola SuperFola mentioned this issue Oct 5, 2019
Closed
@SuperFola SuperFola added this to To Do in v3.1.0 Oct 5, 2019
SuperFola added a commit that referenced this issue Oct 6, 2019
@SuperFola
adding Ark::State as stated in #35
2a0cacd
@SuperFola
Copy link
Member Author

SuperFola commented Oct 6, 2019 •
edited
Loading

Well, the Ark::State thing is done and working, but the std::list used to imporve performances is worse than I thought (in term of performances).

v3.1.0 automation moved this from To Do to Done Oct 6, 2019
@SuperFola SuperFola added this to the 3.1.0 milestone Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ark/virtual machine Related to the ark virtual machine enhancement New feature or request 👍 good first issue Good for newcomers
Projects
No open projects
v3.1.0
  
Done
Milestone
3.1.0
Development

No branches or pull requests
1 participant
@SuperFola