New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1066 added Traditional Chinese, which is a more complete new translation function. #1068
Comments
hi! thanks for your translation. i'll check your submition asap and build a pre-release so you can check if it's all fine with your translation |
Ok you have worked hard |
Just a simple question: I know there are no good relations between China and Taiwan. |
Could I use the same icon (china flag) for both? |
Here is a pre-release https://github.com/arkypita/LaserGRBL/releases/tag/v3.5.4 |
If you are distracted, you can put the flag of Hong Kong. They are in traditional Chinese. |
I have seen that you also add a translation file for "StandardMaterials.psh" database. Unfortunately for now I did not foresee the possibility of using translations in the material database because it uses a slightly different mechanism. I'll think about it, let's see what can be done. |
As for the choice between traditional and simplified Chinese, I seem to have understood that the most correct language codes would be zh-Hans (simplified) and zh-Hant (traditional), which are language codes not linked to a specific territory. zh-CN means "Simplified and using Mainland Chinese terms" and zh-TW means "Traditional and using Taiwanese terms" It therefore seems that hans / hant are more "all-inclusive" as a definition, while -TW or -HK are regional variants. This makes you lose some automatisms that allow LaserGRBL to start automatically with the right language from the first run. |
I added Traditional Chinese, which is a more complete new translation function.
But I don’t know if my usage is correct, I have uploaded support and made a request.
Can you help me determine?#1066
The text was updated successfully, but these errors were encountered: