Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1066 added Traditional Chinese, which is a more complete new translation function. #1068

Open
onmaker opened this issue Jul 5, 2020 · 9 comments

Comments

@onmaker
Copy link
Contributor

onmaker commented Jul 5, 2020

I added Traditional Chinese, which is a more complete new translation function.
But I don’t know if my usage is correct, I have uploaded support and made a request.
Can you help me determine?#1066

@onmaker onmaker changed the title added Traditional Chinese, which is a more complete new translation function. #1066 added Traditional Chinese, which is a more complete new translation function. Jul 5, 2020
@arkypita
Copy link
Owner

arkypita commented Jul 5, 2020

hi! thanks for your translation.
give me time, i am a little busy this days

i'll check your submition asap and build a pre-release so you can check if it's all fine with your translation

@onmaker
Copy link
Contributor Author

onmaker commented Jul 7, 2020

Ok you have worked hard
Thanks for your help
If you have any questions about the translation, please tell me how to modify it

@arkypita
Copy link
Owner

arkypita commented Jul 9, 2020

Just a simple question:

I know there are no good relations between China and Taiwan.
What is the right text and the right flags to use for the two (traditional chinese and simplified chinese) menu items? Something politically correct.

@arkypita
Copy link
Owner

arkypita commented Jul 9, 2020

Could I use the same icon (china flag) for both?

@arkypita
Copy link
Owner

arkypita commented Jul 9, 2020

Here is a pre-release https://github.com/arkypita/LaserGRBL/releases/tag/v3.5.4

@onmaker
Copy link
Contributor Author

onmaker commented Jul 10, 2020

阿裡旺旺圖片20200710152756
Some of the displays here are limited, and may require a pull-out window or pull bar

In addition, we will check later to verify how the program and translation work, and then update again.
In addition, there seems to be a place where Chinese has not been updated. I think this is because the area where he is located is the plugin area, so you cannot translate, or you have not put it? . as follows
81368
81367

@onmaker
Copy link
Contributor Author

onmaker commented Jul 10, 2020

我可以同時使用相同的圖標(中國國旗)嗎?

If you are distracted, you can put the flag of Hong Kong. They are in traditional Chinese.
This will not cause trouble.

@arkypita
Copy link
Owner

I have seen that you also add a translation file for "StandardMaterials.psh" database.

Unfortunately for now I did not foresee the possibility of using translations in the material database because it uses a slightly different mechanism. I'll think about it, let's see what can be done.

@arkypita
Copy link
Owner

As for the choice between traditional and simplified Chinese, I seem to have understood that the most correct language codes would be zh-Hans (simplified) and zh-Hant (traditional), which are language codes not linked to a specific territory.

zh-CN means "Simplified and using Mainland Chinese terms" and zh-TW means "Traditional and using Taiwanese terms"

https://en.wikipedia.org/wiki/Chinese_Wikipedia#Automatic_conversion_between_traditional_and_simplified_Chinese_characters

It therefore seems that hans / hant are more "all-inclusive" as a definition, while -TW or -HK are regional variants.

image

This makes you lose some automatisms that allow LaserGRBL to start automatically with the right language from the first run.
However this is a very small problem, because it is always possible to manually choose a language in LaserGRBL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants