Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider treating id types as completely opaque #529

Closed
mzeitlin11 opened this issue Apr 7, 2024 · 0 comments
Closed

Consider treating id types as completely opaque #529

mzeitlin11 opened this issue Apr 7, 2024 · 0 comments

Comments

@mzeitlin11
Copy link
Collaborator

mzeitlin11 commented Apr 7, 2024

Is your feature request related to a problem? Please describe.

cc @arlyon, I'd like to propose removing the prefix-based validation of ids in the next branch. Beyond the added complexity and large number of issues (and since there is no documentation of them), it seems like a compatibility hazard given Stripe's statement here

Stripe considers the following changes to be backwards-compatible:
- Changing the length or format of opaque strings, such as object IDs, error messages, and other human-readable strings.
- This includes adding or removing fixed prefixes (such as ch_ on charge IDs).

This potential source of failed requests will be more problematic with miniserde since it won't even provide a useful error indicating the prefix issue.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant