Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing arm_s8_to_s16_unordered_with_offset.c when I included the pack #101

Closed
tonywu-uec opened this issue Feb 5, 2024 · 3 comments
Closed

missing arm_s8_to_s16_unordered_with_offset.c when I included the pack #101

tonywu-uec opened this issue Feb 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@tonywu-uec
Copy link

I try to incorporate the CMSIS-NN into my project. However, I saw error message:

.\objects\myProject.axf: Error: L6218E: Undefined symbol arm_s8_to_s16_unordered_with_offset (referred from arm_convolve_s8.o).

I traced the function in the CMSIS-NN and found out the source code arm_s8_to_s16_unordered_with_offset.c is in the
directory C:\Users\XXX\AppData\Local\Arm\Packs\ARM\CMSIS-NN\4.1.0\Source\NNSupportFunctions. But the pack didn't
include the file.

CMSIS-NN File List - 1
CMSIS-NN File List - 2
CMSIS-NN File List - 3

Did the pack miss it accidentally? How can I add it back into the pack?

Best Regards,

/Tony
@mansnils
Copy link
Contributor

mansnils commented Feb 5, 2024 •
edited
Loading

Hi @tonywu-uec
Unfortunately there was a mistake in the 4.1.0 pack/component, sorry about that. Perhaps this will work?

  • Rename the pack to a zip file
  • Unzip and add to ARM.CMSIS-NN.pdsc
  • Rezip and rename to original name

Or if you could use the 5.0.0 CMSIS-NN pack/component instead?

@iga31
Copy link

iga31 commented Feb 27, 2024

Hi @mansnils
arm_nn_mat_mult_kernel_row_offset_s8_s16.c and arm_nn_vec_mat_mul_result_acc_s8_s16.c
are not included in current pdsc.

@mansnils
Copy link
Contributor

Thanks @iga31. We will will fix this.

@felix-johnny felix-johnny added the bug Something isn't working label Feb 27, 2024
@mansnils mansnils mentioned this issue Mar 28, 2024
Merged
mansnils added a commit that referenced this issue Apr 2, 2024
@mansnils
Add missing MVE support for int16 convolution (#124)
1af62f8 
- Removes arm_convolve_s16
- Updates arm_nn_mat_mul_kernel_s16.c to be used by scalar and DSP
- Adds arm_nn_mat_mult_nt_t_s16.c with MVE support
- Refactors and renames arm_convolve_fast_s16 to arm_convolve_s16 so
that all variants use the previously named fast s16 version.
- Updates unit tests to increase test coverage for convolution s16
- Keras based unit test uses null bias as opposed to array with zeroes
- Correct PDSC file

BUGS=#101
#119
@mansnils mansnils closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mansnils @felix-johnny @tonywu-uec @iga31