Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Numbers #13

Closed
shivupa opened this issue Jul 2, 2018 · 2 comments
Closed

Magic Numbers #13

shivupa opened this issue Jul 2, 2018 · 2 comments

Comments

@shivupa
Copy link

shivupa commented Jul 2, 2018

Can these please be replaced with named constants? Preferably with the formula/units in a comment? I think this code has educational utility beyond what is intended. The project is structured well and the code is written well so it is readable. I could imagine more advanced students reading the source and learning something.
E.g.

// four_ep_sigma (UNITS) = 4 * \epsilon * \sigma**6 
four_ep_sigma = 9.273e-78

Instances that I saw:

@arm61
Copy link
Owner

arm61 commented Jul 2, 2018

I think that I have managed to get all of the examples of "magic numbers" out of the code. I would be grateful if you would check #15 just to confirm?

@shivupa
Copy link
Author

shivupa commented Jul 3, 2018

I believe that covers it. Thanks!

@shivupa shivupa closed this as completed Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants