Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accent colors in the upstream changed #3

Open
AKorezin opened this issue Apr 15, 2023 · 2 comments
Open

Accent colors in the upstream changed #3

AKorezin opened this issue Apr 15, 2023 · 2 comments

Comments

@AKorezin
Copy link

Summary

Colors for the default theme are a bit off since the last changes for the 2.0 release of mint-themes.
I think the current values of the constants should be here.
https://github.com/linuxmint/mint-themes/blob/master/constants.py

Current behavior

current_qt

current_gtk

Expected behavior

expected_qt

Version

  • mint-themes: 2.0.9
  • kvantum-mint-y: 1.0.0

Possible fix

Update the colors from the upstream version of https://github.com/linuxmint/mint-themes/blame/master/constants.py.

Locally I used a patch that changes

  • 92b372 -> 35a854
  • 8fa876 -> 35a854
  • b7865e -> 9c7e65

Here's a part of it for build_subthemes.py

--- a/build_subthemes.py
+++ b/build_subthemes.py
@@ -14,7 +14,7 @@
     GNU General Public License for more details.
 """
 
-baseColors = ( 0x92b372, 0x8fa876 );
+baseColors = ( 0x35a854, 0x35a854 );
 baseThemes = ( "Mint-Y", "Mint-Y-Dark" );
 
 subBaseColors = ( 0x859b6f, 0xafca95, 0x779559 );
@@ -22,7 +22,7 @@ subBaseColors = ( 0x859b6f, 0xafca95, 0x779559 );
 subthemes = {
 	"Aqua":   0x1f9ede,
 	"Blue":   0x0c75de,
-	"Brown": (0xb7865e, 0xaa876a),
+	"Brown": (0x9c7e65, 0xaa876a),
 	"Grey":   0x70737a,
 	"Orange": 0xff7139,
 	"Pink":   0xe54980,
armanelgtron added a commit that referenced this issue Apr 17, 2023
change the base theme to actually be the "legacy" theme, and build the
new "Mint-Y" off that

see #3
@armanelgtron
Copy link
Owner

Hi, thanks for letting me know.

For now, I've changed it so the current base theme in 1.0.0 will now be the "Legacy" theme, and the script will generate the new "Mint-Y" and "Mint-Y-Dark" themes with the new colors from that.

@AKorezin
Copy link
Author

AKorezin commented Apr 17, 2023

Hi, and what about Brown?

Mint-Y-Brown accent color should be #aa876a.
Mint-Y-Dark-Brown accent color should be #9c7e65.
It seems the build script can't properly generate the dark theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants