-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centre Button Selectable Conflicts with Custom Icon #46
Comments
Its an or clause. It checks whether IconColorFilter is enabled or the centreButton is selectable. |
Hi @Kogoro, thanks for the reply. I am using the centre button as my main app screen. This means the centre button should be selectable with none of the other buttons selected. However, I would also like to disable color filtering because it interferes with other images in my app. Currently, setting the centre button as selectable forces the user to use a color filter as setting color filter to false has no effect. |
But should you not provide some feedback when clicking the centrebutton? I mean we could change it to an And that should solve this problem. Then the color would not change to white in default when selected. I try to do this in the next days when I'm free. |
Hmm, that is an interesting problem. Do you mean that there will be no ripple effect if a custom icon is used? |
In the actual implementation, the icon will get an inactive color. The reason is that the icon should indicate the active page. The inactive color can be set with inactive_centre_button_icon_color, the active color with active_centre_button_icon_color. When you disable the IconColorFilter and we change the code to an And, the icon will have the standard icon color defined by the image at the first start. After a selection of the centreButton it is normal again when isSelectable=true. Hope that clears your question. ;) |
@searchy2 This only affects the color which is set at the beginning. It will not change the behavior between iconcolorfilter and centrebuttonselectable. |
@Kogoro
Using spaceNavigationView.setCentreButtonIconColorFilterEnabled(false);
does not work when spaceNavigationView.setCentreButtonSelectable(true); is also used.
You mentioned that you use a custom icon, how are you able to get your custom icon to show?
The text was updated successfully, but these errors were encountered: