Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to recv() from connection [7]! Bad address. #16

Closed
JeremyGrosser opened this issue Feb 4, 2013 · 3 comments
Closed

Failed to recv() from connection [7]! Bad address. #16

JeremyGrosser opened this issue Feb 4, 2013 · 3 comments

Comments

@JeremyGrosser
Copy link

When I start statsite and send UDP messages to it (eg. "cn.nginx.latency:45|ms\n"), I see the following message on stdout:

statsite[7686]: Failed to recv() from connection [7]! Bad address.

Digging in a bit more, these start once statsd receives a malformed stat on the udp port. For example:

my.stats.are.bad

With no value causes close_client_connection(handle->conn); to be called on the UDP socket in conn_handler.c:308. This causes all further recv() calls to that socket to fail.

@JeremyGrosser
Copy link
Author

Seeing the same issue with malformed values as well as missing ones.

[pid 18891] recvfrom(7, "dispatch.production.foo:undefined|g", 262143, 0, NULL, NULL) = 53
[pid 18891] sendto(3, "<132>Feb 4 22:46:16 statsite[18890]: Failed value conversion! Input: undefined", 79, MSG_NOSIGNAL, NULL, 0) = 79

@armon
Copy link
Collaborator

armon commented Feb 4, 2013

Thanks for reporting. I added an integration test to confirm this and sure enough it's there.
The fix and the test for it are now in master. Please give that a try. I think the issue is closed now.

@armon
Copy link
Collaborator

armon commented Feb 5, 2013

Marking this as closed now.

@armon armon closed this as completed Feb 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants