Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotator code is totally incorrect #2167

Open
vtereshkov opened this issue Apr 22, 2021 · 0 comments
Open

Rotator code is totally incorrect #2167

vtereshkov opened this issue Apr 22, 2021 · 0 comments
Labels
bug This issue describes a bug

Comments

@vtereshkov
Copy link

Description
Roll, pitch and yaw do not constitute a vector. In practice it means that:

  • When you add, subtract, multiply, interpolate, normalize orientations as vectors, you get meaningless quantities
  • The (roll, pitch, yaw) triad does not define the rotation axis direction
  • The final orientation depends on the order in which the roll, pitch and yaw rotations are applied
  • There are orientations that are not representable by roll, pitch and yaw

You have to do one of the following:

  • Treat roll, pitch and yaw as separate scalars that obey the Euler equations
  • Represent orientation by a 3 x 3 rotation matrix
  • Represent orientation by a quaternion

Options 2 and 3 imply that roll, pitch and yaw, if needed, are computed by request and never used for intermediate computations.

@vtereshkov vtereshkov added the bug This issue describes a bug label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a bug
Projects
None yet
Development

No branches or pull requests

1 participant