Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nishita sky crashes when strength set to zero. #2937

Closed
e2002e opened this issue Oct 1, 2023 · 5 comments
Closed

Nishita sky crashes when strength set to zero. #2937

e2002e opened this issue Oct 1, 2023 · 5 comments
Labels
bug This issue describes a bug

Comments

@e2002e
Copy link
Contributor

e2002e commented Oct 1, 2023

Thank you for contributing to Armory!

When using a nishita sky and setting the environment light to 0, crashes occur:
double free or corruption (out)
WARNING: Player exited code -6
.
Blender: 3.6
Armory: lattest
OS: PopOS
Graphics card: rtx 3050 driver 535

@e2002e e2002e added the bug This issue describes a bug label Oct 1, 2023
@MoritzBrueckner
Copy link
Collaborator

Hi, I'm assuming the crash happens on Krom? I can't reproduce this and I'm a bit surprised that the crashes only seem to happen when you set the env strength to 0, as this only changes a shader uniform. However, there was an issue with Nishita skies in Krom builds that I fixed in armory3d/armorcore#64, unfortunately this fix will not make it into the SDK until armory3d/armorcore#63 gets fixed... Maybe check the fixes with a custom Krom build, if you know how to compile it.

@rpaladin
Copy link
Contributor

rpaladin commented Oct 3, 2023

If you created this issue as an intentionally misleading false report, just so you could nag for a code review, then that's rather despicable behavior on your part, in my opinion.

Please stop spamming unprepared pull-requests and false issue tracker reports.

@e2002e
Copy link
Contributor Author

e2002e commented Oct 3, 2023

@rpaladin, no that is never my intention.

@e2002e
Copy link
Contributor Author

e2002e commented Oct 3, 2023

I'm closing this since I can't reproduce the issue.
I was quite sure that using a nishita sky with 0 strength would allow for a lit sky without the environment light.
This doesn't hold true right now, don't know why. Sorry about the disturbancy.

@e2002e e2002e closed this as completed Oct 3, 2023
@e2002e
Copy link
Contributor Author

e2002e commented Oct 6, 2023

I'm reopening since this is still an issue.
I tested the code again, with nvidia drivers 510, and the exit code is now -11.

@e2002e e2002e reopened this Oct 6, 2023
@e2002e e2002e closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a bug
Projects
None yet
Development

No branches or pull requests

3 participants