You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thing to improve wrt the download from PlutoF as is coded currently (July 27)
I had sent you a spreadsheet with the corrected names of the stations, please include those corrections: for example Swedish_West_coast should be "SWC". The hard-coded syntax corrections you have in that code are otherwise OK and should remain as such, only the station names need to be taken from this spreadsheet
Please add an error check/alert to your download: if a station is downloaded that is not in my spreadsheet, inform me and I will update the spreadsheet. Maybe we should put that correction spreadsheet somewhere in GitHub (rather than attached to this issue)?
In addition to the other hard-coded syntax fixes you implement in your code, please add a "remove spaces": the gulf of piran arms units called Luka KP and Boja Vida, for example, need to be changed to LukaKP and BojaVida
I think your code is, however, too harsh in that the station called Greenland has now arms units called 1 2 3 1 2 3, rather than Nuuk1/2/3 and Danebork1/2/3. Please fix this but in a way that is future-proof, not just for this next download
The same comment for the station called Laeso
If you think we need to discuss a better way to manage this QC of the station and arms unit names, probably better to do so before Aug 12. In the end it may be better to use my input to correct these names, rather than hard-coding, but with alerts for when something new is encountered that I have not yet provided input for
Station names are now corrected better, however there are differences between my QC CSV file input and what is in PlutoF, and that is not caught by the script. So first I need to update the QC CSV input and second the code needs to catch these differences. I will raise that as a new issue.
Thing to improve wrt the download from PlutoF as is coded currently (July 27)
If you think we need to discuss a better way to manage this QC of the station and arms unit names, probably better to do so before Aug 12. In the end it may be better to use my input to correct these names, rather than hard-coding, but with alerts for when something new is encountered that I have not yet provided input for
The spreadsheet with the corrections to apply to the station and arms names:
PlutoF_QC_v2_StationARMSnames.csv
The text was updated successfully, but these errors were encountered: