Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing naming #10

Open
MarioProjects opened this issue Feb 17, 2021 · 0 comments
Open

Confusing naming #10

MarioProjects opened this issue Feb 17, 2021 · 0 comments

Comments

@MarioProjects
Copy link

MarioProjects commented Feb 17, 2021

Hi, your code is very clean thanks!

But I think that naming can be confusing. At https://github.com/arnab39/cycleGAN-PyTorch/blob/master/model.py#L107 you named a_fake = self.Gab(b_real), the generator of a to b taking a b example should not generate the identity (a_idt)? In all examples I show, the followed nomenclature for generators is this Gxy, generator from x to y...

Assuming that, all generators naming are reversed. What do you think?

@MarioProjects MarioProjects changed the title Naming confusion Confusing naming Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant