New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`$get_contributions()` doesn't handle namesakes #15

Closed

arnaudgallou opened this issue Aug 6, 2023 · 0 comments · Fixed by #20

Labels

bug feature Plume

Owner

arnaudgallou commented Aug 6, 2023 •

edited

aut <- Plume$new(tibble::tibble(
  given_name = c("Zip", "Zip"),
  family_name = c("Zap", "Zap"),
  role_1 = c("a", NA),
  role_2 = c("b", "b")
))
aut$get_contributions(roles_first = FALSE, by_author = TRUE)
#> Z.Z.: a, b and b

arnaudgallou added the bug label

arnaudgallou changed the title ~~$get_contributions() doesn't work with namesakes~~ $get_contributions() doesn't handle namesakes

arnaudgallou added the feature label

arnaudgallou mentioned this issue

Make $get_contributions() handle namesakes #20

Merged

arnaudgallou closed this as completed in #20

arnaudgallou added the Plume label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment