Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't build #7

Closed
ptzld opened this issue Oct 21, 2022 · 4 comments
Closed

Doesn't build #7

ptzld opened this issue Oct 21, 2022 · 4 comments

Comments

@ptzld
Copy link

ptzld commented Oct 21, 2022

mismatched types
--> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/cursive-0.10.0/src/backend/termion.rs:222:46
|
222 | let terminal = AlternateScreen::from(MouseTerminal::from(
| _____________________________________^
223 | | ::std::io::stdout().into_raw_mode().unwrap(),
224 | | ));
| |
^ expected struct AlternateScreen, found struct MouseTerminal
|
= note: expected struct AlternateScreen<_>
found struct MouseTerminal<RawTerminal<Stdout>>

For more information about this error, try rustc --explain E0308.
error: could not compile cursive due to previous error
warning: build failed, waiting for other jobs to finish...

@Arnavion
Copy link
Owner

Well, that's a bug in cursive or termion that one of them didn't handle semver correctly. But of course this repo is using 2-year-old versions so there's no point reporting it to them.

I don't maintain this any more since my ThinkPad spends most of its time turned off these days, but I'll see how much effort it is to just update deps to latest.

@Arnavion
Copy link
Owner

Actually, it still repros with cursive 0.20.0 and termion 1.6.0. Turns out it's a semver-breaking API change in termion 1.6.0 - https://gitlab.redox-os.org/redox-os/termion/-/commit/0082c8da04f861b677dee1e8da9c56bdffd3f422 removed AlternateScreen::from

@jackpot51 FYI

@jackpot51
Copy link

I yanked 1.6.0 and will re-release as 2.0.0, thanks for the notice.

@jackpot51
Copy link

Done, with migration guide: https://crates.io/crates/termion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants