Allow to use http package instead of http2 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow this never got into my inbox so I'm super late to this, but thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few months ago, we had to switch the request logic to
http2since Figma APIs need HTTP2 to support large responses from this API.This works well on mobile, but not on web, where HTTP2 isn't surfaced (the current
FigmaClientimplementation can't be used with web target) and is just used under the hood when available . This means that regular http requests become in fact HTTP2 requests under the hood, depending on the web browser and requests headers.To summarize, we have to use
http2on mobile/desktop, andhttpon web.