Cleaned up the code and made the toolbar button intelligently enable/disable

[kabiroberai]

The title (and commits) say it all. I've removed a lot of things that I didn't think were needed, but if they are supposed to be for future features, feel free to select what to merge.

[kabiroberai]

There also seem to be a few bugs with the toolbar enabling/disabling thing, and I think that activate isn't always being called on tab change. This may be worth looking into.

[kabiroberai]

Also, this doesn't seem to be working with Netflix, since the video tag there seems to be loaded dynamically (it may require a Mutation Observer).

[arnoappenzeller]

I'm going to look into it in the next few days but already thanks in advance - sounds fantastic.

Netflix worked for me a few weeks ago but maybe they did some changes in their code

[arnoappenzeller]

The cleanup is very welcome and you finally made the activation feature work.

Didn't think about the Mutation Observer - this was where I was stuck in the first place so I'm merging this!

Will also add the additions for the AppStore version soon

Thanks so much!

[kabiroberai]

@arnoappenzeller no problem 👍 Also, I've made another commit in my fork that removes both the local reference to stateManager (now there's no self capturing in validateToolbarItem's getActivePage), and the firstCheck variable in script.js (instead, previousResult is now null during the first loop). You could manually do those here or I can make another PR if you want.

[arnoappenzeller]

Feel free to add another PR :-)

Otherwise I'm currently working on a new feature (adds buttons directly to popular players) which I will push later or next weekish then I can include those changes

[arnoappenzeller]

I added some of your changes in 2d783e0

I didn't add the changes to the js because after a while the button didn't activate/deactivate properly in my tests.

[kabiroberai]

@arnoappenzeller I figured out the issue (it happens even with the old logic), so expect a PR soon :)