New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many video sources aren't opening Safari's PiP now (this includes new YouTube, Vimeo, Twitch, Netflix, and others!) #37
Comments
I have submitted what appears to be a bug with Safari that's causing this here: https://bugs.webkit.org/show_bug.cgi?id=172051 |
From my newer comments on the Safari bug tracker:
Triggering a PiP shouldn't require a bookmarklet or using the context menu of the video element while using the |
Also, it appears this issue isn't just restricted to Potential fix for now:I wonder if making this extension trigger itself as if it were a bookmarklet would be the overall fix until Safari changes this behavior. |
Hmm not sure how this will affect the final versions of Safari but I will definitely look into this when the new macOS beta is out. But thank you for filing this odd behaviour |
Any update on this? Seems alot of sources aren't working anymore :/ |
Noticed the same thing as well with |
@arnoappenzeller Checked on High Sierra and it's exactly the same issue. |
Can you try to disable the setting for pip button on popular sites and observe if it is still the same? As I said I can’t reproduce this atm. |
Just let you know FACEBOOK works like a charm. Thank you. |
I'm using Safari Technology Preview 29, and it seems Pipifier isn't able to convert YouTube & other video services into a PiP if they're using a
blob:
URL as theFor example, I can use
document.getElementsByTagName('video')[0]
to pull the exact YouTube video player element, but thendocument.getElementsByTagName('video')[0].webkitSetPresentationMode('picture-in-picture');
just returns "undefined" and the PiP isn't triggered. Meanwhile, it appears that you can use the right-click & then right-click again on the YouTube video player to then choose the PiP option from Safari's context menu to have it work just fine.I'm not sure if this is something WebKit/Safari needs to fix for PiPifier to function or if there's something needing to be updated within PiPifier. I figured I'd mention the issue I came across.
The text was updated successfully, but these errors were encountered: