-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diff pane swapping continued #429
Comments
Looks good, my option would be the header option, with an icon like this Thanks! |
I merged the PR, looks good. I have swapped the SVG for your second option. |
|
Confirmed available and has the new features in. Thanks! |
Following on from #425, you commented:
Would something like this be welcomed?
On my local fork I have also played about with this - which I think might be slightly better due to visual feedback of the checkbox being checked when the panels are swapped.
As an aside, I think it might be worth adding the options
originalEditable: false
andreadonly:true
to prevent any confusion when viewing a diff using ServiceNow-Utils. Unless I am missing something, we cannot actually merge & save code from this editor screen. Example of code in playground:https://microsoft.github.io/monaco-editor/playground.html?source=v0.40.0#XQAAAAIiAgAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw0jtAyAEiAJM8XEuX7Os378jBGtVLkr6ryuhqvky-XZ9Sy0vyFSI1m9lYQpwqOsaKmhydYWIo-9hGbv_4wlPIsEpVooDN3UCgYV8kLlvOGD8rooZ1WJ_A9v5uEdBOb0AipkE4Iowchu_BgMrpPL1Ntca8LopanXcEtdWz5KKsCh_UeVKP09Ty-lq0ScxsMyFQQoUHz7UPS1WD1Zt2NUeQwejieA3tWHC64SHWxaIEtaudKU_jy4daAiOJfZ0ya6sgo9_Zqi7MyIr8lyZUQyiJKG7INZZeTBGtHGX5yhjnQLc_D5qY8MPfL5OPqOeo__A7HQ4
The text was updated successfully, but these errors were encountered: