Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff pane swapping continued #429

Closed
PromoFaux opened this issue Aug 21, 2023 · 4 comments
Closed

Diff pane swapping continued #429

PromoFaux opened this issue Aug 21, 2023 · 4 comments

Comments

@PromoFaux
Copy link
Contributor

Following on from #425, you commented:

Add a swap icon button in the header at the division line to make this capability less hidden.

Would something like this be welcomed?

POC

On my local fork I have also played about with this - which I think might be slightly better due to visual feedback of the checkbox being checked when the panels are swapped.

diff

As an aside, I think it might be worth adding the options originalEditable: false and readonly:true to prevent any confusion when viewing a diff using ServiceNow-Utils. Unless I am missing something, we cannot actually merge & save code from this editor screen. Example of code in playground:

https://microsoft.github.io/monaco-editor/playground.html?source=v0.40.0#XQAAAAIiAgAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw0jtAyAEiAJM8XEuX7Os378jBGtVLkr6ryuhqvky-XZ9Sy0vyFSI1m9lYQpwqOsaKmhydYWIo-9hGbv_4wlPIsEpVooDN3UCgYV8kLlvOGD8rooZ1WJ_A9v5uEdBOb0AipkE4Iowchu_BgMrpPL1Ntca8LopanXcEtdWz5KKsCh_UeVKP09Ty-lq0ScxsMyFQQoUHz7UPS1WD1Zt2NUeQwejieA3tWHC64SHWxaIEtaudKU_jy4daAiOJfZ0ya6sgo9_Zqi7MyIr8lyZUQyiJKG7INZZeTBGtHGX5yhjnQLc_D5qY8MPfL5OPqOeo__A7HQ4

@arnoudkooi
Copy link
Owner

Looks good, my option would be the header option, with an icon like this
However, the checkbox is fine as well. Also, the read-only seems a good idea.
Btw could you DM me on one of the platforms or email me? apps@arnoudkooi.com

Thanks!

@arnoudkooi
Copy link
Owner

I merged the PR, looks good. I have swapped the SVG for your second option.
I'll update this issue when the new version 7.1.2.0 is published

@arnoudkooi
Copy link
Owner

I'll update this issue when the new version 7.1.2.0 is published
should be available

@PromoFaux
Copy link
Contributor Author

Confirmed available and has the new features in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants