Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bump mapping #5

Closed
aromanro opened this issue Jun 14, 2020 · 2 comments
Closed

Add bump mapping #5

aromanro opened this issue Jun 14, 2020 · 2 comments
Assignees
@aromanro
Labels
enhancement

Comments

@aromanro
Copy link
Owner

If I recall correctly, for some planets I found bump mapping textures. It would be nice to add bump mapping at least for one (preferably Earth). Just add an optional parameter for each planet/moon for the bump mapping texture and if one is available for a planet/moon, do bump mapping https://en.wikipedia.org/wiki/Bump_mapping.
@aromanro aromanro self-assigned this Jun 14, 2020
@aromanro
Copy link
Owner Author

aromanro commented Jun 14, 2020 •
edited
Loading

Just checked, there are bump maps and normal maps https://en.wikipedia.org/wiki/Normal_mapping available for some of the planets/moons.

@aromanro
Copy link
Owner Author

aromanro commented Jul 4, 2020

Done. There might be some issues with some normal maps out there (not all I found seem to be ok) but bump mapping / normal mapping works now. If a bump map / height map is provided (8 bpp gray image), a normal map is computed using Sobel.

@aromanro aromanro closed this as completed Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aromanro aromanro

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aromanro