Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD sandbox code for fullscreen_mode + REMOVE: spin from player (rarely used?) #824

Merged
merged 2 commits into from
Jun 20, 2019

Conversation

hainm
Copy link
Collaborator

@hainm hainm commented Jun 20, 2019

Absolutely a sandbox code

from nglview.sandbox.grid_view import fullscreen_mode

fullscreen_mode(view) # will add a `Fullscreen` button to the player

Screen Shot 2019-06-20 at 1 20 41 AM

@hainm hainm merged commit 4384641 into nglviewer:master Jun 20, 2019
@hainm hainm deleted the fullscreen_mode branch July 11, 2019 18:51
@ostrokach
Copy link

Is there a more nuanced reason as to why the "spin" option was removed? I came to GitHub looking for this specific feature...

@ostrokach
Copy link

ostrokach commented Oct 26, 2019

Ah, nevermind. As long as the feature is still available, I guess it does not matter if it is exposed through _display.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants