Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gridbox enhancement #838

Merged
merged 15 commits into from Jul 24, 2019
Merged

Gridbox enhancement #838

merged 15 commits into from Jul 24, 2019

Conversation

hainm
Copy link
Collaborator

@hainm hainm commented Jul 23, 2019

  • add handle_resize for backend and handleResszie for frontend: The idea is that we can properly resize the view's container if the view is in nested boxes.
  • add EXPERIMENTAL Fullscreen class to handle fullscreen.
  • Add syncing repr between two views of two models (I am not sure about this usage).

@hainm hainm changed the title Gridbox ENH Gridbox enhancement Jul 23, 2019
@hainm
Copy link
Collaborator Author

hainm commented Jul 24, 2019

before:
Screen Shot 2019-07-23 at 11 43 10 PM

after:
Screen Shot 2019-07-23 at 11 43 17 PM

PS: ideally we don't need handle_resize at all. Don't have clean implementation yet.

@hainm hainm merged commit dea146c into nglviewer:master Jul 24, 2019
@hainm hainm deleted the gridbox-2 branch July 24, 2019 03:44
@hainm
Copy link
Collaborator Author

hainm commented Jul 24, 2019

may be

class GridBox2(Gridbox):
     def __init__(self, *args, **kwargs):
        [bla bla]
        self.on_displayed(self.handle_display)
    def handle_display(self):
        for v in self.children:
           v.handle_resize()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant