Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete site shows data after adding it back #714

Closed
woutrbe opened this issue Dec 23, 2023 · 4 comments
Closed

Delete site shows data after adding it back #714

woutrbe opened this issue Dec 23, 2023 · 4 comments

Comments

@woutrbe
Copy link

woutrbe commented Dec 23, 2023

I recently deleted a site from my account, and about a week later added it back, however I'm still seeing the previous data from this site. Is there some sort of grace period?

On the deleting page, it does say;

This will remove all associated data and is the current site.

I haven't actively investigated this further, but does this potentially open the door to being able to see data from deleted sites from other accounts?

@arp242
Copy link
Owner

arp242 commented Dec 23, 2023

It "soft-deletes" for a week and then it permanently removes stuff, just in case people change their minds. The "undelete" is intentional, although I can see how that's confusing.

does this potentially open the door to being able to see data from deleted sites from other accounts?

No, it should check for that: https://github.com/arp242/goatcounter/blob/d2bd78c/handlers/settings.go#L292-L294

@woutrbe
Copy link
Author

woutrbe commented Dec 23, 2023

Thanks for the quick answer, that makes sense. I sort of guessed that’s how it would work, but wanted to raise it anyway, just in case.

i think it might be helpful to mention this on the delete page, to avoid confusion.

@arp242
Copy link
Owner

arp242 commented Dec 23, 2023

i think it might be helpful to mention this on the delete page, to avoid confusion.

I might just remove it; need to think about it but it would make everything simpler. It's been like this since day one, but it hasn't really come up very often; I think only one person has asked to "undelete" their site. I added the "undelete" much later after someone did what you did: delete site and then re-create it. But just deleting everything would have been fine there too.

And all things considered, it's not really that important data in the grand scheme of things, and I do have backups if it is (although it's a pain to restore one site from them, it can be done).

@arp242
Copy link
Owner

arp242 commented Dec 23, 2023

In the meanwhile, what you can do is first rename the site you want to delete, then delete it, and then re-use that name for a new site.

Or you can just delete all data from "manage pageviews" and entering "%".

@woutrbe woutrbe closed this as completed Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants