Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: e is undefined in count.min.js #77

Closed
betaveros opened this issue Dec 6, 2019 · 1 comment
Closed

TypeError: e is undefined in count.min.js #77

betaveros opened this issue Dec 6, 2019 · 1 comment
Labels

Comments

@betaveros
Copy link

Visiting my website with goatcounter gives this error:
2019-12-06-183356_1920x1080_scrot

I only looked through the code very cursorily but 85f3c30 looks suspicious — count now takes one argument count_vars instead of none, but the invocation of count() on load at the bottom passes in zero arguments.

@arp242
Copy link
Owner

arp242 commented Dec 7, 2019

Thanks, I fixed it when I woke up this morning: db1a509. What a silly error; sorry :-( I had tested it on my own site before deploy using the proxy script, but I forgot that I include the script in the page directly (it's a bit faster that way), so the new version never got loaded 🤦

I spent quite some time trying to add decent tests to the JavaScript code a few months ago, but wasn't really able to find a good solution. There are many JS testing frameworks, but I'm not a huge fan of these kind of large framework and would prefer a simple "test runner". I spent some time trying to get my own solution working, but the whole browser context thing makes stuff kinda tricky and had loads of other things to do as well :-/

@arp242 arp242 closed this as completed Dec 7, 2019
@arp242 arp242 added the bug label Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants