New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
componentWillReceiveProps warning in React 16.9 #649
Comments
Is there any work done on this? This repo can't be used with React v.17+, once it it arrives. |
Any further updates? Would prefer to not have to find another date and time picker... |
Any news on this? |
Sorry about the delay when replying. This issue is already been handled in the v3 branch that's going to be released soon, we've just need to update the docs there before releasing. |
@arqex Could you add a hot fix to the v2?, because I have afraid of breakchanges. |
The band-aid that removes that warning from the console is implemented in this pull request: #674 That PR is not currently passing the CI due to a pre-existing problem in master, which my friend David identified and fixed in this pull request: #684 Once his PR gets merged, I'll update mine so it will pass the CI too. Having both merged would be great because then you'd be able to leave V2 working and without warnings, so those of us that can't simply upgrade to V3 will still have a clean console. <3 |
By the way, tried v3 and value does not work well using a state hook variable. I mean, the value get applied but when the view gets oppened, it shows the current month. If you navigate to the date that was set to the variable, the day was correctly selected. I noticed that there's an internal state inputValue that doesn't get updated. Best regards. |
Hey @codebury I don't get what you mean, could you set an example for me forking this sandbox? |
Hi! Yes, of course: https://codesandbox.io/s/reverent-worker-60drr Thanks for quick reply. |
@codebury Thanks for the example, I missed the notification and I've just had a look now. I know now what you mean, and you are right it's something to fix before the big release. @TrishaPatel Sorry about the warnings, but still no fix for that. Anyway I don't think your issues are related to any update of the v2 of library, seems that you are having some z-index issues in that images. |
ya I am trying to fix that manually. But it was working fine. I don't know after which update it is showing like this. |
Hi all, how does it look like with the fix of componentWillReceiveProps warning? It's a bit annoying. Thanks for the update! |
Hi all, any updates for this one? |
Thanks for raising the issue, and sorry for the delay! It's fixed as part of version 3 🙂 |
I just wanted to point out that I updated to react@16.9.0 and react-dom@16.9.0 and got the following warning in the console:
The text was updated successfully, but these errors were encountered: