Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgotten 'console.log' in the code #746

Open
bryandidur opened this issue Oct 14, 2020 · 7 comments
Open

Forgotten 'console.log' in the code #746

bryandidur opened this issue Oct 14, 2020 · 7 comments

Comments

@bryandidur
Copy link

I'm Submitting a ...

[x] Bug report
[ ] Feature request
[ ] Support request

Steps to Reproduce

  1. Clicking on the datetime input logs a "CLICKING 2!" message in the console.

Expected Results

No debug logs.

Actual Results

Logs a "CLICKING 2!" message in the developer console.

Minimal Reproduction of the Problem

See this sandbox to inspect the debug message https://codesandbox.io/s/lively-worker-vsqu1?file=/src/App.js

Other Information (e.g. stacktraces, related issues, suggestions how to fix)

None

@SachaG
Copy link
Contributor

SachaG commented Oct 22, 2020

Glad I'm not the only one who sometimes forgets console.logs in production code!

@Ashirogi-Muto
Copy link

I just checked out the file DateTime.js, the source of the log and I didn't find the log statement! Am I doing something wrong?

@bryandidur
Copy link
Author

I don't know. But the log exists, as you can see in the sandbox.

@Ashirogi-Muto
Copy link

I am using this library in my company's product which is built in React and yes I can see the log there too!

@ali-wells
Copy link

It seems to be in the minified version sitting in the dist directory, I think it needs re-building from the current source as DateTime.js doesn't have that line now

@johnhunter
Copy link

Should probably add eslint rule https://eslint.org/docs/rules/no-console

@NoPhaseNoKill
Copy link

Do we have an ETA on when this will be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants