Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postActions could be resolved after tools registration #53

Open
smiklosovic opened this issue Jun 25, 2015 · 2 comments
Open

postActions could be resolved after tools registration #53

smiklosovic opened this issue Jun 25, 2015 · 2 comments

Comments

@smiklosovic
Copy link
Member

Right now, in default installation, there is this (1) and after it, there is tool registration.

However, I can imagine that the installation could register tools which you want to use in post installation closure but as it is done now - they are not existing yet.

The workaround is to make custom installation which calls postActions.resolve() in registerTools() method after all tools are registered hence, to my understanding, invocation of postActions will have access to just registered tools.

(1)

@smiklosovic
Copy link
Member Author

@kpiwko

@kpiwko
Copy link
Member

kpiwko commented Jul 3, 2015

Yes, this one is problematic. However, it is also the other way around - there might be steps needed to do prior registration itself

Unclear whether we want to have 2 closures. Likely some renaming and having just one with clear behavior will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants