Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of stripped down version of Gradle plugin #57

Open
smiklosovic opened this issue Feb 1, 2016 · 3 comments
Open

Release of stripped down version of Gradle plugin #57

smiklosovic opened this issue Feb 1, 2016 · 3 comments

Comments

@smiklosovic
Copy link
Member

@aslakknutsen @kpiwko @MatousJobanek

I need this plugin and I found it obsolete. It is not possible to import it into the IDE anymore, it uses arcane Gradle 2.3 instead of newer 2.9 / 2.10 and so on.

I started massive clean of source code, it is obvious that back then, we were using Groovy in a different manner and it is just not a pleasant look in general.

My idea is to completely get rid of existing tasks so it will be only bare Gradle plugin itself and nothing more. I think that it was in general bad idea to develop tasks with plugin. Tasks should be completely externalized.

I want to ask if you are able and willing to release this stripped down version of plugin. It can be renamed to have -stripped suffix or something similar and it can live in a separate branch.

Are you ok with this and can you do this in a window of 1 week? If the answer is negative, I would have to fork you and release it myself as I want or I would try to update that old plugin to cover Gradle of version 2.9 and make it importable to Idea and leave complete clean out of scope.

What do you prefer?

@kpiwko
Copy link
Member

kpiwko commented Feb 2, 2016

@smiklosovic what are you trying to achieve? What would be functionality of "Bare Gradle Plugin"?

  • Can you provide more technical data about next plugin functionality? E.g. what problem would the plugin achieve?
  • What do you mean by get rid of existing tasks? Some of the tasks, such as Download is needed for Bare Plugin, if I understand you plan correctly

I don't mind giving you access this repository and make you the owner of this plugin, in my understanding you are likely the only one using it at this moment - with a possible exception of Drone integration tests. However, I'd expect you to do -stripped related work in such case ;-).

As a side note, I personally think that a test/installation should be a Gradle Task - this is another wrong decision about the plugin.

@smiklosovic
Copy link
Member Author

@kpiwko

Firstly I want to update Gradle to 2.9 so I tried to import that into the IDE and it was marked as errorneous. So I kind of repair it and started its tests and Android installation was failing and I do not have time to deal with it anymore at all so I just @Ignore-d that test and when I look at it, I will hardly ever repair it and I do not want to have there something which smells and does not work.

So I started to delete tasks and I deleted so much of them that the idea of having completely pure plugin with core tasks (like maven executor, some xml tasks, arquillian.xml tasks and git) sounds reasonable to me and that is pretty much it ... I would like to have something small and updated rather then to have something broken and not used.

However, I understand that it can be viewed as unnecessary and I can easilly go only with update to newer Gradle and that's it.

@smiklosovic
Copy link
Member Author

@kpiwko

I will send both "solutions" during the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants