New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter selected tests based on testsToRun first instead of filtering it in selectTests method of TestStrategyApplier #70

Closed
dipak-pawar opened this Issue Jul 26, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@dipak-pawar
Contributor

dipak-pawar commented Jul 26, 2017

Issue Overview

Currently we are filtering tests on TestsToRun in TestStrategyApplier

I believe we can improve it by filtering it little early on getTests of respective strategy. e.g. in NewTestsDetector

It will definitely help in improving performace

@MatousJobanek

This comment has been minimized.

Show comment
Hide comment
@MatousJobanek

MatousJobanek Jul 26, 2017

Contributor

This is what I was pointing out when I wanted to pass only tests that will be run (eg. here: #51 (comment)).
And not only for new test strategy but for all TestExecutionPlanner implementation.

Contributor

MatousJobanek commented Jul 26, 2017

This is what I was pointing out when I wanted to pass only tests that will be run (eg. here: #51 (comment)).
And not only for new test strategy but for all TestExecutionPlanner implementation.

@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Jul 26, 2017

Member

This would only work for surefire though, we have to think how to model it properly so it will be useful not only for this use case. API needs to be universal and we cannot have leaky abstractions.

Feel free to share your ideas in this issue with some code examples. That would help designing this.

Member

bartoszmajsak commented Jul 26, 2017

This would only work for surefire though, we have to think how to model it properly so it will be useful not only for this use case. API needs to be universal and we cannot have leaky abstractions.

Feel free to share your ideas in this issue with some code examples. That would help designing this.

@bartoszmajsak

This comment has been minimized.

Show comment
Hide comment
@bartoszmajsak

bartoszmajsak Aug 22, 2017

Member

With TestVerifier interface in place it's now possible.

Member

bartoszmajsak commented Aug 22, 2017

With TestVerifier interface in place it's now possible.

@bartoszmajsak bartoszmajsak added this to the 0.0.1 milestone Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment