Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal on ja-heavy-testing #65

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Conversation

rachelcarmena
Copy link
Member

Goal

This is a pull request on ja-heavy-testing:

Details

I think idea-plugin doesn't need to use testing-plugin but kotlin-compile-testing:

details-testing-library

@i-walker
Copy link
Member

i-walker commented Nov 4, 2019

We definitely can use kotlin-compile-testing this PR has the same problem as #63.

Do you know how we can fix the Internal Error that we're getting?
if you run clean :idea-plugin:test you can see it.
It is similar to this: https://intellij-support.jetbrains.com/hc/en-us/community/posts/115000712004-How-to-integrate-KotlinPlugin-s-PSI-classes?page=1#community_comment_115000609590
But the solution is undocumented.

@i-walker
Copy link
Member

i-walker commented Nov 4, 2019

Thank you @rachelcarmena.
We can keep this as a draft until we find a solution for the internal_error. This doesn't have to happen this week.

@jansorg
Copy link
Contributor

jansorg commented Nov 4, 2019

As long as it‘s possible to generate .class files from a code snippet, I‘m all for replacing testing-plugin.

@rachelcarmena
Copy link
Member Author

As long as it‘s possible to generate .class files from a code snippet, I‘m all for replacing testing-plugin.

Great @jansorg! Yes, it's possible to generate .class files from a code snippet.

testing-plugin is using kotlin-compiler-testing to get them.

@ahinchman1
Copy link
Collaborator

Hey @rachelcarmena! I was hoping for some clarification - would it be necessary to use the testing-plugin if we wanted to write tests for the IDE or is the plan to separate the testing setup into their respective projects?

@rachelcarmena
Copy link
Member Author

rachelcarmena commented Nov 7, 2019

Hey @rachelcarmena! I was hoping for some clarification - would it be necessary to use the testing-plugin if we wanted to write tests for the IDE or is the plan to separate the testing setup into their respective projects?

It seems the tests for the IDE just need the compiled files and that's already provided by kotlin-compile-testing.

testing-plugin is not ready for that need and adds more things that tests for the IDE wouldn't use.

That's the reason why it makes sense to use kotlin-compile-testing for IDE tests.

@jansorg jansorg merged commit e63f761 into ja-heavy-testing Nov 8, 2019
@jansorg
Copy link
Contributor

jansorg commented Nov 8, 2019

@rachelcarmena I've merged your commits into ja-heavy-testing (#57). Thank you for the proposal, this definitely simplifies the compiler integration!

@rachelcarmena rachelcarmena deleted the proposal/ja-heavy-testing branch November 8, 2019 11:37
@rachelcarmena
Copy link
Member Author

Thanks to you @jansorg !! Good to know it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants