Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github stars #1923

Closed
AntonioMateoGomez opened this issue Jan 13, 2020 · 3 comments · Fixed by #1934
Closed

Github stars #1923

AntonioMateoGomez opened this issue Jan 13, 2020 · 3 comments · Fixed by #1934
Assignees
Labels

Comments

@AntonioMateoGomez
Copy link
Collaborator

AntonioMateoGomez commented Jan 13, 2020

We are going to bring back github stars to the new design.
In the future when we separate the Arrow modules in different repos, all libraries (Core, Optics, Incubator, Meta, Fx) should point to a single star count, that of the main arrow repo. When all libs are split out that repo will remain as the index of what is in the arrow org.

Besides we are going to implement a modal card that link to the Arrow stars.
Captura de pantalla 2020-01-15 a las 15 00 27

Once user closes it won´t appears anymore in that session so it won´t be anoying.

This must be implemented in every Arrow module. Here is the link to the Arrow Meta issue

@jnorthrup
Copy link

I may be alone in measuring two different arrow sub-projects on the basis of their individual merits, and contributors as separate contributors, but I would definitely downgrade something that was 5 stars in all respects a star or two by conflating the projects, the contributors, all things as one point of publicity and likely classify this as purely commercial by any popup ratings dialogs. I hope i speak only for myself in expressing these views, and not as any other viewer of the subprojects i have starred (this one is not, but it is self-explanatory why I am directed here).

@raulraja
Copy link
Member

@jnorthrup feel free to downgrade your stars as you wish.
Arrow is splitting from the monorepo where all stars were into many individual repos after two years and becoming a collection of libs that interoperate with each other but have a common purpose. The monorepo will be left empty after the split and as you can imagine we are not about to get rid of all those stars. The overall star count if possible will include all the repos of arrow in the site but you can still star individually each repo if you wish.

@AntonioMateoGomez
Copy link
Collaborator Author

Hi @jnorthrup , I have edited the issue description because I think it´s beign misunderstood.

This was referenced Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants